code review request for minor FDS tweak (7157296, 7158067)
Daniel D. Daugherty
daniel.daugherty at oracle.com
Fri Mar 30 15:00:32 PDT 2012
Adding the other aliases back in...
The <reply-list> button only replies to one list... :-(
On 3/30/12 3:47 PM, James Melvin wrote:
> Hi Dan,
> Looking at the root, hotspot and jdk repos.... Wow. BUILD_FLAVOR is
> expensive ice cream! Thumbs Up. Nice work here on FDS makefile magic.
> - Jim
> On 3/30/12 1:32 PM, Daniel D. Daugherty wrote:
>> In my recent Full Debug Symbols changes, I added the new
>> ENABLE_FULL_DEBUG_SYMBOLS build flag. I originally implemented
>> this flag to disable debug info for all build configs which
>> doesn't make a whole lot of sense for non-product builds. After all
>> what's a debug build without debug info? (Pretty much the same
>> thing as a product build).
>> As is usual, I have one bug to track the hotspot repo changes and
>> another bug to track the other repos:
>> 7157296 3/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
>> OPT builds
>> 7158067 4/4 FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect
>> product builds
>> Here are the webrev URLs:
>> Thanks, in advance, for any review comments.
More information about the build-dev