RR(XS): JDK-8022617 Openjdk hotspot build is broken on BSD platforms using gcc
david.holmes at oracle.com
Thu Aug 29 10:49:42 UTC 2013
This needs to be reviewed by the hotspot group.
I don't understand your change given we already had:
AS = $(CC) -c -x assembler-with-cpp
Isn't this something that was fixed very recently?
Your change, as far as I can see, will also add the assembler-with-cpp
to clang not just gcc.
On 29/08/2013 7:09 PM, Dmitry Samersoff wrote:
> Thank you for the comments.
> Please, take a look to updated webrev:
> On 2013-08-29 04:41, David Holmes wrote:
>> I don't think this is something that should be handled at the configure
>> level. Hotspot compiler flags are handled in the hotspot makefiles. This
>> should be in gcc.make.
>> BTW your changeset should include the generated-configure.sh file not
>> configure. And you would also need to regenerate and push the closed
>> generated-configure.sh file.
>> On 28/08/2013 11:50 PM, Dmitry Samersoff wrote:
>>> Hi Everyone,
>>> Please review small fix
>>> Gory details:
>>> bsd_x86_64.s use macro to deal with OS X specific things.
>>> llvm-gcc preprocess .s and .S files and doesn't support .sx extension
>>> recommended by GNU for case insensitive filesystem.
>>> Other operating systems doesn't preprocess .s files, so bsd_x86_64.s
>>> couldn't be compiled on other bsd systems.
>>> This patch enforce of preprocessing of all assembly sources by
>>> command line options (-x assembler-with-cpp).
More information about the build-dev