RFR: JDK-8201236 Straighten out dtrace build logic

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Apr 9 17:23:52 UTC 2018


On 2018-04-06 17:23, Erik Joelsson wrote:
> Looks good in general.
>
> In JvmDtraceObjects.gmk, comment on line 38 needs to be updated.
Nice spotting! It was left-over from before. I deleted it, the paragraph 
above said the same thing but correctly.

/Magnus
>
> /Erik
>
>
> On 2018-04-06 03:57, Magnus Ihse Bursie wrote:
>> The dtrace build logic was copied straight out of the old Hotspot 
>> build system, and is quite convoluted.
>>
>> It should be split into the separate parts it actually contains of:
>> 1) A gensrc step which runs with other gensrc ahead of compilation
>> 2) Two independent libraries that can be build at any time
>> 3) Two special dtrace-generated .o files that must be linked with the 
>> JVM
>>
>> I have also cleaned up includes in generateJvmOffsets.cpp.
>>
>> I have verified with COMPARE_BUILD that no changes has happened in 
>> any native library.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201236
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8201236-straighten-out-dtrace/webrev.01
>>
>> /Magnus
>



More information about the build-dev mailing list