On the recent push into jdk8/build
kelly.ohair at oracle.com
Wed Apr 11 08:32:15 PDT 2012
When I was creating the official changesets of the new makefiles I did run into a few issues with whitespace.
Two sources, one a .c file in the root repo, and one a java source file in the jdk repo, had whitespace issues I fixed.
Official changesets have to get past the jcheck extension, and that includes whitespace checks.
The whitespace rules apply to any .c, .h, .cpp, .hpp, and .java files:
* No TAB characters
* No trailing whitespace on lines
* No more than one blank line at the end of the file
In addition, it tries to check to make sure no files have execute permission. Which made me wonder about the
instructions for running configure, we may need to tell them to run "sh configure" because the configure file
will not have execute permissions by default.
The jcheck extension also verifies the changeset comment syntax and the validity of the author and reviewer names.
It also makes sure that the CR number appears valid (just in form, no communication with the bugtraq system),
and that no other changeset in the repository uses this same CR number.
Not exactly what will happen when bugtraq goes away, ultimately a good thing, but jcheck (and JPRT) will need
to adjust with regards to what a CR looks like.
More information about the build-infra-dev