hg: build-infra/jdk8/corba: Excluding files from compile that aren't compiled in the old build.
erik.joelsson at oracle.com
Thu Jan 19 22:46:52 PST 2012
The java files I listed below fit your description. They are just not
listed in the FILES_java-files. The package PortableActivationIDL is a
bit different. The source is generated by the idl compiler, but never
compiled by javac. There is a Makefile for compiling it, but from what I
can tell, it's never called.
In this project I'm of course just trying to produce the exact same
result as the old build, but another project might be to clean these
weird things up. Source should either be compiled into the product or
not be there at all, and should certainly not be eating up build time by
being partly compiled and then thrown away.
On 2012-01-19 17:30, Kelly O'Hair wrote:
> Some of the old old Makefile had Files.gmk files that explicitly listed the java source files.
> Many were wrong.
> Years ago when I tried to get rid of the explicit file lists, there were some that I did not fix because fixing the
> issues would have added more class files to the JDK that I wasn't sure was right.
> Unfortunately, when it comes to corba, no many people know any answers.
> I doubt the exclusion was explicit or on purpose, but I don't know what the consequences are of adding them in.
> Sometimes, the explicit lists of sources being incomplete was not an issue because due to implicit compilation
> the missing sources would get dragged in because of dependencies and the class files showed up anyway.
> Ignore the src.zip, it is delivered as an independent thing and has nothing to do with what is actually compiled, has some specific
> rules about how it is created and what can get into it.
> On Jan 19, 2012, at 5:19 AM, Erik Joelsson wrote:
>> I find the excluded files here weird. The sources are still included in the src.zip. Does anyone know why these files aren't compiled into the product? It seems to me the exclusion isn't explicit in the old build system.
>> The files in question are:
>> com/sun/corba/se/spi/presentation/rmi/StubWrapper.java \
>> com/sun/org/omg/CORBA/IDLTypeOperations.java \
>> com/sun/org/omg/CORBA/IRObjectOperations.java \
>> On 2012-01-19 13:23, erik.joelsson at oracle.com wrote:
>>> Changeset: bc755e1c21cc
>>> Author: erikj
>>> Date: 2012-01-19 13:23 +0100
>>> URL: http://hg.openjdk.java.net/build-infra/jdk8/corba/rev/bc755e1c21cc
>>> Excluding files from compile that aren't compiled in the old build.
>>> ! makefiles/Makefile
More information about the build-infra-dev