Code review for 7086595: Error message bug: name of initializer is 'null'
Dmitry.Degrave at oracle.com
Tue Dec 6 05:18:29 PST 2011
On 12/06/2011 04:21 PM, Dalibor Topic wrote:
> On 12/6/11 11:09 AM, Dmeetry Degrave wrote:
>> On 12/05/2011 11:08 PM, Dalibor Topic wrote:
>>> On 12/4/11 5:09 PM, Dmeetry Degrave wrote:
>>>> I see some uncertainties if fixes are pushed to previous releases without a review,
>>>> - every push to repo needs a reviewer. It's mandatory, isn't ?
>>> Yes, but jdk7u has a shortcut, so to speak - since we share many, if not all, reviewers with jdk8,
>>> and in general want changes to go into jdk8, you don't need to have a separate review of an identical
>>> fix for jdk7u that has gone into jdk8 already.
>> to be crystal clear here, whose openjdk name is supposed to be used in "Reviewed-by:" field ?
> The same as in the push to the jdk8 forest.
it looks strange to make "Reviewed-by" statement with name of a person
who hasn't seen actual changes that are going to be pushed.
> dalibor topic
More information about the compiler-dev