RFR: JDK 8194892: add compiler support for local-variable syntax for lambda parameters
maurizio.cimadamore at oracle.com
Wed Feb 14 15:38:41 UTC 2018
On 14/02/18 15:31, Vicente Romero wrote:
> Hi Maurizio,
> Thanks for the comments. I have updated the webrev after the
> modifications you proposed plus the snapshot of the diagnotics:
> On 02/14/2018 05:59 AM, Maurizio Cimadamore wrote:
>> Looks good; minor quibbles:
>> * Changes in ParserFactory and JavacParser (for adding diagnostic
>> factory) seem unnecessary?
>> * the diagnostic say 'explicitly-typed parameters' which is a term
>> that also appear in the spec, so good! But they say 'implicit
>> parameters' - which is inconsistent both with the other fragment and
>> with the spec. I suggest replacing with 'implicitly-typed' parameters.
>> Would also help to have some snapshot of the new diagnostics being
>> On 13/02/18 20:49, Vicente Romero wrote:
>>> Please review the implementation for JEP 323: Local-Variable Syntax
>>> for Lambda Parameters .
>>> The specification has been made public at . The current
>>> implementation for the spec can be found at .
>>>  https://bugs.openjdk.java.net/browse/JDK-8193259
>>>  http://cr.openjdk.java.net/~vromero/8194892/webrev.00/
More information about the compiler-dev