JDK 12 RFR of JDK-8206085 : Refactor langtools/tools/javac/versions/Versions.java
joe.darcy at oracle.com
Tue Jul 3 23:03:51 UTC 2018
On 7/3/2018 2:51 AM, Maurizio Cimadamore wrote:
> Looks good.
> I believe the test could be further automatized, by adding more logic
> to the enum. E.g. each constant could define in a string a snippet of
> code that is unique to that version (and maybe the BASE version would
> have an empty snippet). That way the sources could be generated
> programatically - no need to repeat various headers etc. Also, I
> believe once you go down this path, it could be even possible to have
> a single checksrc method which takes a couple of version constants,
> generate the sources for them using the templating strategy described
> E.g. it would be great if all the 'mutable' parts would be contained
> to the enum declaration - adding enum constants is rather easy,
> especially when the structure is clearly self-explanatory (as in this
Thanks for the review.
Further refactoring for another day; this test has some a long way from
its earlier days as a shell script!
More information about the compiler-dev