JDK 12 RFR of JDK-8207055 : Make javac -help output for -source and -target more informative
joe.darcy at oracle.com
Wed Jul 11 22:30:03 UTC 2018
On 7/11/2018 2:18 PM, Jonathan Gibbons wrote:
> On 07/11/2018 11:18 AM, joe darcy wrote:
>> Please review the changes to implement
>> JDK-8207055 : Make javac -help output for -source and -target
>> more informative
>> Basically the -help output for -source and -target is augmented to
>> include a concatenation of the supported values for those options. It
>> would be possible to write the concatenation in a more stream-y
>> manner, but I think the loops are sufficient.
> OK, but ...
> While not without precedent, the use of the string ", " to create a
> string for a list is not correct in all locales.
> Perhaps separately, we should create and use a utility method to
> convert a list to a string.
Thanks for the review; adding a localized list-ifier javac utility
method sounds like a good refactoring.
More information about the compiler-dev