<html>
  <head>

    <meta http-equiv="content-type" content="text/html; charset=windows-1252">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <div class="moz-forward-container"><br>
      <br>
      -------- Original Message --------
      <table class="moz-email-headers-table" cellpadding="0"
        cellspacing="0" border="0">
        <tbody>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
            </th>
            <td>Re: Review Request - 2 : JDK-8031670: remove unneeded
              -source option from javadoc tests</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
            <td>Mon, 03 Mar 2014 09:08:26 -0800</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
            <td>Neil Toda <a class="moz-txt-link-rfc2396E" href="mailto:neil.toda@oracle.com">&lt;neil.toda@oracle.com&gt;</a></td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Organization:
            </th>
            <td>Oracle Corporation</td>
          </tr>
          <tr>
            <th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
            <td>Vicente-Arturo Romero-Zaldivar
              <a class="moz-txt-link-rfc2396E" href="mailto:vicente.romero@oracle.com">&lt;vicente.romero@oracle.com&gt;</a></td>
          </tr>
        </tbody>
      </table>
      <br>
      <br>
      <meta content="text/html; charset=windows-1252"
        http-equiv="Content-Type">
      <br>
      I'll fix that.  Thanks Vicente.<br>
      <br>
      -neil<br>
      <br>
      <div class="moz-cite-prefix">On 3/1/2014 1:02 PM, Vicente-Arturo
        Romero-Zaldivar wrote:<br>
      </div>
      <blockquote cite="mid:53124AE4.1070102@oracle.com" type="cite">
        <meta content="text/html; charset=windows-1252"
          http-equiv="Content-Type">
        <div class="moz-cite-prefix">On 27/02/14 16:13, Neil Toda wrote:<br>
        </div>
        <blockquote cite="mid:530F6416.2080004@oracle.com" type="cite">
          <meta http-equiv="content-type" content="text/html;
            charset=windows-1252">
          This is a Review Request resubmission with reviewer-based
          changes.<br>
          <br>
          Original Description:<br>
          <blockquote>A small set of javadoc tests contain the -source
            parameter.  In most cases, the parameter is <br>
            not required for the test.  In several cases, the -source
            parameter is being explicitly tested, <br>
            but relies on a JDK version that will be removed from JDK9.
            <br>
            <br>
            This changeset removes unnecessary -source specification
            when not needed, or changes the <br>
            test/source-version requested to one that will work in JDK9<br>
          </blockquote>
          <br>
          The revised changeset-webrev can be found here:<br>
          <div class="moz-forward-container">
            <div class="moz-cite-prefix"> <br>
                  <a moz-do-not-send="true"
                class="moz-txt-link-freetext"
                href="http://cr.openjdk.java.net/%7Edarcy/neiltoda/8031670.1/">http://cr.openjdk.java.net/~darcy/neiltoda/8031670.1/</a><br>
            </div>
          </div>
        </blockquote>
        <br>
        Hi,<br>
        <br>
        The change is OK for me, there is a typo in a test note of test:
        test/tools/javadoc/sourceOption/SourceOption.java<br>
        <br>
        "With JDK9, <u>this this</u> test has been transformed into a
        NEGATIVE test."<br>
        <br>
        You don't need another review round for this.<br>
        <br>
        Thanks,<br>
        Vicente.<br>
        <br>
        <blockquote cite="mid:530F6416.2080004@oracle.com" type="cite">
          <div class="moz-forward-container">
            <div class="moz-cite-prefix"> <br>
              <br>
              Changes from first submittal:<br>
              <br>
                * in
              ./test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java<br>
                  * correct spelling error : amy -&gt; may<br>
                  * remove comment on test from jtreg tag block<br>
                * to validate -source option operation<br>
                  * reinstate ./sourceOption test<br>
                  * in
              ./test/tools/javadoc/sourceOption/SourceOption.java<br>
                    * changed to a negative test to make sure javac
              lambda construct is not in 1.7<br>
                    * add information about updating test periodically<br>
                    * add a fixVersion bug [ set to 1.10 for current
              targeted feature ]<br>
                  * added
              ./test/tools/javadoc/sourceOption/p/LambdaConstructTest.java<br>
                    * valid for 1.8, but not for 1.7. "-source 1.7" is
              checked with this code.<br>
                  * added
              ./test/tools/javadoc/sourceOption2/SourceOption2.java<br>
                    * This test is a positive test to make sure that the
              lambda construct provided for ./sourceOption is valid for
              8.<br>
                    * This test is actually examining
              ./sourceOption/p/LambdaConstructTest.java<br>
              <br>
              Thanks<br>
              <br>
              -neil<br>
              <br>
            </div>
          </div>
        </blockquote>
        <br>
      </blockquote>
      <br>
      <br>
    </div>
    <br>
  </body>
</html>