<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Yes, I verified that as well, so we're
      good to push the patch.<br>
      <br>
      -- jon<br>
      <br>
      On 04/27/2016 06:24 AM, Jeremy Manson wrote:<br>
    </div>
    <blockquote
cite="mid:CAPYFHW3252P1Mt+oscipApoo05AMF-8u0730ebKCc-1MAaJW4A@mail.gmail.com"
      type="cite">
      <div dir="ltr">FWIW, it is correct for new files we contribute to
        have Google copyright.  As Liam points out, we've done that
        before in multiple places.
        <div><br>
        </div>
        <div>It doesn't make any difference to the GPL or Oracle's
          ability to relicense.<br>
          <div><br>
          </div>
          <div>Jeremy</div>
        </div>
      </div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Thu, Apr 21, 2016 at 4:59 PM, Liam
          Miller-Cushon <span dir="ltr"><<a moz-do-not-send="true"
              href="mailto:cushon@google.com" target="_blank">cushon@google.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div dir="ltr">
              <div class="gmail_extra">
                <div class="gmail_quote">
                  <div>Thanks for the review! The updated patch is
                    attached.<br>
                  </div>
                  <span class="">
                    <div> </div>
                    <blockquote class="gmail_quote" style="margin:0px
                      0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">*
                      since the issue can be exposed in two ways
                      (reflection and separate compilation), I'd like to
                      see two tests; you have one for reflection -
                      having also the other for separate compilation
                      would be great (since that area tends to get
                      neglected)</blockquote>
                    <div><br>
                    </div>
                  </span>
                  <div>To confirm, do you mean the "<span
                      style="color:rgb(0,0,0)">javac -implicit:none
                      Other.java" example in the original thread? I
                      added that to the test.</span></div>
                  <div><span style="color:rgb(0,0,0)"><br>
                    </span></div>
                  <div><span style="color:rgb(0,0,0)">I also thought
                      about testing against a bad class file, but that
                      doesn't exercise anything in the patch and I don't
                      have a good way to generate a class with the
                      problem (ASM won't write classes with this issue,
                      and now javac won't either).</span></div>
                  <span class="">
                    <div> </div>
                    <blockquote class="gmail_quote" style="margin:0px
                      0px 0px
0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">*
                      I'm not a lawyer - and I'm not sure whether the
                      copyright header in your test is correct ;-)</blockquote>
                    <div><br>
                    </div>
                  </span>
                  <div>Oops. Any concerns with using the same header
                    (except for the date) as this: <a
                      moz-do-not-send="true"
href="http://hg.openjdk.java.net/jdk9/dev/jdk/file/c0f3840e225a/test/java/util/zip/EntryCount64k.java"
                      target="_blank">http://hg.openjdk.java.net/jdk9/dev/jdk/file/c0f3840e225a/test/java/util/zip/EntryCount64k.java</a>?</div>
                  <div><br>
                  </div>
                </div>
              </div>
            </div>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>