<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Thanks Paul.<br>
    <br>
    I'm doing final checks and preparations of fixes to<br>
    <br>
        JDK-8173382: Add -source 11 and -target 11 to javac<br>
        JDK-8193291: Add SourceVersion.RELEASE_11<br>
    <br>
    and expect to push shortly.<br>
    <br>
    Cheers,<br>
    <br>
    -Joe<br>
    <br>
    <div class="moz-cite-prefix">On 12/18/2017 5:42 PM, Paul Sandoz
      wrote:<br>
    </div>
    <blockquote
      cite="mid:1BFAF81C-7292-4699-B696-85FB637A19D2@oracle.com"
      type="cite">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      Looks good to me.
      <div class=""><br class="">
      </div>
      <div class="">I am including HS dev for the class file version
        changes:</div>
      <div class=""><br class="">
      </div>
      <div class="">  <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epsandoz/jdk/JDK-8173382-classfile-version/webrev/"
          class="">http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/</a></div>
      <div class="">  <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epsandoz/jdk/JDK-8173382-classfile-version-build-changes/webrev/"
          class="">http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version-build-changes/webrev/</a><br
          class="">
        <div><br class="">
        </div>
        <div>We can push the above patches under the following issue
          rather that merge into Joe's patch:</div>
        <div><br class="">
        </div>
        <div>  <a moz-do-not-send="true"
            href="https://bugs.openjdk.java.net/browse/JDK-8191913"
            class="">https://bugs.openjdk.java.net/browse/JDK-8191913</a></div>
        <div><br class="">
        </div>
        <div>Hopefully by the next release we can merge together and
          with less changes required.</div>
        <div><br class="">
        </div>
        <div>Paul.</div>
        <div><br class="">
          <blockquote type="cite" class="">
            <div class="">On 18 Dec 2017, at 17:33, Joseph D. Darcy <<a
                moz-do-not-send="true"
                href="mailto:joe.darcy@oracle.com" class="">joe.darcy@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <div class="">Hello,<br class="">
                <br class="">
                A follow-up on defining a final field RELEASE_CURRENT
                 as an alias for the latest SourceVersion constant to
                allow easier updating of annotations using SourceVersion
                constants. Somewht surprisingly, this is not legal Java
                code; an annotation must use an enum constant directly
                and not a constant expression which evaluates to an enum
                constant.<br class="">
                <br class="">
                This rules is given in JLS 9.7.1 Normal Annotations:<br
                  class="">
                <br class="">
                <blockquote type="cite" class="">T [ the element type]
                  is not an array type, and the type of V [the element
                  value] is assignment compatible (§5.2) with T, and:<br
                    class="">
                  <br class="">
                     If T is a primitive type or String, then V is a
                  constant expression (§15.28).<br class="">
                     If T is Class or an invocation of Class (§4.5),
                  then V is a class literal (§15.8.2).<br class="">
                     If T is an enum type (§8.9), then V is an enum
                  constant (§8.9.1).<br class="">
                     V is not null.<br class="">
                </blockquote>
                <a moz-do-not-send="true"
href="https://docs.oracle.com/javase/specs/jls/se9/html/jls-9.html#jls-9.7.1"
                  class="">https://docs.oracle.com/javase/specs/jls/se9/html/jls-9.html#jls-9.7.1</a><br
                  class="">
                <br class="">
                The wording goes back to JLS 3rd edition which
                introduced enums and annotations.<br class="">
                <br class="">
                Formally, the constant expression concept in JLS 15.28
                only applies to primitive types and Strings. Presumably,
                it would not be too difficult to expand this concept to
                include class literals and enum constants.<br class="">
                <br class="">
                In any case, in the mean time the suggested idiom will
                not work and the changes of RELEASE_9 => RELEASE_10
                will need to stay.<br class="">
                <br class="">
                Updated webrev with a minor merge:<br class="">
                <br class="">
                   <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~darcy/8173382.3/">http://cr.openjdk.java.net/~darcy/8173382.3/</a><br
                  class="">
                <br class="">
                Cheers,<br class="">
                <br class="">
                -Joe<br class="">
                <br class="">
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
    <br>
  </body>
</html>