<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>It's a crash. Once it is approved, you can push to the jdk/jdk11
      repo.</p>
    <p>-- Jon<br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 7/5/18 10:03 AM, Liam Miller-Cushon
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAL4Qsgsfh4ZcT_Zq_C23OZxrhXHDxB-pCzfCtcKrMAkRTWqUug@mail.gmail.com">
      <div dir="ltr">Ping. Should I defer this to 12?</div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr">On Thu, Jun 28, 2018 at 5:19 PM Liam
          Miller-Cushon <<a href="mailto:cushon@google.com"
            moz-do-not-send="true">cushon@google.com</a>> wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0 0 0
          .8ex;border-left:1px #ccc solid;padding-left:1ex">
          <div dir="ltr">Hi,<br>
            <div><br>
            </div>
            <div>Is there any more feedback on this?</div>
            <div><br>
            </div>
            <div>The bug is currently targeted for JDK 11, but I can
              defer it if there are any concerns.</div>
            <div><br>
            </div>
            <div>Thanks,</div>
            <div>Liam</div>
          </div>
          <br>
          <div class="gmail_quote">
            <div dir="ltr">On Tue, Jun 12, 2018 at 7:50 PM Liam
              Miller-Cushon <<a href="mailto:cushon@google.com"
                target="_blank" moz-do-not-send="true">cushon@google.com</a>>
              wrote:<br>
            </div>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex">
              <div dir="ltr">Hi Jan,<br>
                <br>
                Thanks for the review, and the explanation!<br>
                <br>
                <div class="gmail_quote">
                  <div dir="ltr">On Tue, Jun 12, 2018 at 7:13 AM Jan
                    Lahoda <<a href="mailto:jan.lahoda@oracle.com"
                      target="_blank" moz-do-not-send="true">jan.lahoda@oracle.com</a>>
                    wrote:<br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0px 0px
                    0px 0.8ex;border-left:1px solid
                    rgb(204,204,204);padding-left:1ex">So the change in
                    JavacProcessingEnvironment could be, I think,
                    rewritten as:<br>
                    if (cs.owner.kind == PCK) {<br>
                         cs.owner.members().enterIfAbsent(cs);<br>
                    }<br>
                  </blockquote>
                  <div><br>
                  </div>
                  <div>Done. </div>
                  <div><br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0px 0px
                    0px 0.8ex;border-left:1px solid
                    rgb(204,204,204);padding-left:1ex">
                    The change in ClassReader seems unnecessary, or am I
                    mistaken?<br>
                  </blockquote>
                  <div><br>
                  </div>
                  <div>Nope, I think you're right.</div>
                  <div><br>
                  </div>
                  <div>Updated webrev:</div>
                  <div><a
                      href="http://cr.openjdk.java.net/%7Ecushon/8204630/webrev.01/"
                      target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~cushon/8204630/webrev.01/</a></div>
                </div>
              </div>
            </blockquote>
          </div>
        </blockquote>
      </div>
    </blockquote>
    <br>
  </body>
</html>