<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    looks good,<br>
    Vicente<br>
    <br>
    <div class="moz-cite-prefix">On 07/10/2018 08:49 PM, Ivan Gerasimov
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:5d63c456-3807-3829-cf09-02da3ac8262f@oracle.com">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      <p>Thank you Jon!<br>
      </p>
      <br>
      <div class="moz-cite-prefix">On 7/10/18 4:43 PM, Jonathan Gibbons
        wrote:<br>
      </div>
      <blockquote
        cite="mid:efea1d35-fb71-ee84-0995-c9d08e6122b8@oracle.com"
        type="cite">
        <meta http-equiv="Content-Type" content="text/html;
          charset=utf-8">
        <p>In both files, the imports are messed up.</p>
      </blockquote>
      Okay, I can fix it while we're here.<br>
      <br>
      Please find the webrev updated in-place:<br>
      <a class="moz-txt-link-freetext"
        href="http://cr.openjdk.java.net/%7Eigerasim/8206122/01/webrev/"
        moz-do-not-send="true">http://cr.openjdk.java.net/~igerasim/8206122/01/webrev/</a><br>
      <br>
      With kind regards,<br>
      Ivan<br>
      <br>
      <blockquote
        cite="mid:efea1d35-fb71-ee84-0995-c9d08e6122b8@oracle.com"
        type="cite">
        <p>At a minimum, the new imports should be grouped with existing
          imports from the same package.</p>
        <p>-- Jon<br>
        </p>
        <br>
        <div class="moz-cite-prefix">On 7/10/18 4:38 PM, Ivan Gerasimov
          wrote:<br>
        </div>
        <blockquote type="cite"
          cite="mid:0616146a-bdf3-4f2f-b4c9-537e07107927@oracle.com">
          <meta content="text/html; charset=utf-8"
            http-equiv="Content-Type">
          <p>Thank you Martin!<br>
          </p>
          <br>
          <div class="moz-cite-prefix">On 7/10/18 2:32 PM, Martin
            Buchholz wrote:<br>
          </div>
          <blockquote
cite="mid:CA+kOe09ucHvkww-JoAhjD8MYYD1-eLEZemC45t=n3Ytu_qqYOg@mail.gmail.com"
            type="cite">
            <div dir="ltr">I'm happy to see ArrayDeque replacing uses of
              ArrayList.
              <div><br>
              </div>
              <div>
                <pre style="color:rgb(0,0,0);text-decoration-style:initial;text-decoration-color:initial"><span class="gmail-changed" style="color:blue">private final Map<List<String>, Deque<ReusableContext>> options2Contexts = new HashMap<>();</span>
</pre>
                Looks like these Deques are used only via the Queue
                interface. I would either switch to Queue or to
                ArrayDeque (which might help the VM optimize).</div>
            </div>
          </blockquote>
          <br>
          Right.<br>
          I can't remember why I used Deque in one place and Queue in
          the other.<br>
          <br>
          Please find the updated webrev here:<br>
          <a class="moz-txt-link-freetext"
            href="http://cr.openjdk.java.net/%7Eigerasim/8206122/01/webrev/"
            moz-do-not-send="true">http://cr.openjdk.java.net/~igerasim/8206122/01/webrev/</a><br>
          <br>
          With kind regards,<br>
          Ivan<br>
          <br>
          <blockquote
cite="mid:CA+kOe09ucHvkww-JoAhjD8MYYD1-eLEZemC45t=n3Ytu_qqYOg@mail.gmail.com"
            type="cite">
            <div class="gmail_extra"><br>
              <div class="gmail_quote">On Tue, Jul 10, 2018 at 1:54 PM,
                Ivan Gerasimov <span dir="ltr"><<a
                    moz-do-not-send="true"
                    href="mailto:ivan.gerasimov@oracle.com"
                    target="_blank">ivan.gerasimov@oracle.com</a>></span>
                wrote:<br>
                <blockquote class="gmail_quote" style="margin:0 0 0
                  .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello!<br>
                  <br>
                  It is a tiny optimization.<br>
                  <br>
                  There are a couple of places where ArrayList is used
                  as FIFO: elements are appended to the end, and removed
                  from the head.<br>
                  <br>
                  ArrayDeque would be more efficient to use.<br>
                  <br>
                  Would you please help review?<br>
                  <br>
                  BUG: <a moz-do-not-send="true"
                    href="https://bugs.openjdk.java.net/browse/JDK-8206122"
                    rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8206122</a><br>
                  <br>
                  Webrev: <a moz-do-not-send="true"
                    href="http://cr.openjdk.java.net/%7Eigerasim/8206122/00/webrev/"
                    rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~ig<wbr>erasim/8206122/00/webrev/</a><br>
                  <br>
                  Thanks in advance!<span class="HOEnZb"><font
                      color="#888888"><br>
                      <br>
                      -- <br>
                      With kind regards,<br>
                      Ivan Gerasimov<br>
                      <br>
                    </font></span></blockquote>
              </div>
              <br>
            </div>
          </blockquote>
          <br>
          <pre class="moz-signature" cols="72">-- 
With kind regards,
Ivan Gerasimov</pre>
        </blockquote>
        <br>
      </blockquote>
      <br>
      <pre class="moz-signature" cols="72">-- 
With kind regards,
Ivan Gerasimov</pre>
    </blockquote>
    <br>
  </body>
</html>