Miscellaneous improvements to "jar".
Ulf.Zibis at gmx.de
Thu Jun 25 06:20:05 PDT 2009
1. typo in line 1188
2. Is it convention for javadoc to have 2 blanks after period?
3. I guess your change is targeted on performance. IMHO jar read/write
itself should be improved:
Am 25.06.2009 04:34, Martin Buchholz schrieb:
> Hi jar team,
> I have a bunch of minor improvements to
> Toby and Xueming, please review.
> Warning: the index code has not been maintained for many years.
> Xueming, please file a bug.
> Synopsis: Miscellaneous improvements to "jar".
> - Use standard jdk coding style for javadoc
> - Don't create a temp file for jar index in STORED mode.
> - Don't use synchronized collections.
> - Fix javac warnings.
> - Don't define new names for things like INDEX_NAME;
> use static import instead.
> - more efficiently compare special file names in update mode.
> Update mode should be measurably faster.
> - make CRC32OutputStream a nested class.
> refactor crc32.reset and updating entry into CRC32OutputStream.
> - Fix apparently benign bug updating n in
> CRC32OutputStream.write(byte, int, int)
> Evaluation: Yep.
More information about the core-libs-dev