Miscellaneous improvements to "jar".
martinrb at google.com
Thu Jun 25 08:12:43 PDT 2009
Thanks for the review.
On Thu, Jun 25, 2009 at 06:20, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
> 1. typo in line 1188
> 2. Is it convention for javadoc to have 2 blanks after period?
This is not consistent in the JDK. I do it myself, partially because I've
been trained by emacs.
> 3. I guess your change is targeted on performance. IMHO jar read/write
> itself should be improved:
Many things to improve... I'm not planning to work on that one myself.
> Am 25.06.2009 04:34, Martin Buchholz schrieb:
>> Hi jar team,
>> I have a bunch of minor improvements to
>> Toby and Xueming, please review.
>> Warning: the index code has not been maintained for many years.
>> Xueming, please file a bug.
>> Synopsis: Miscellaneous improvements to "jar".
>> - Use standard jdk coding style for javadoc
>> - Don't create a temp file for jar index in STORED mode.
>> - Don't use synchronized collections.
>> - Fix javac warnings.
>> - Don't define new names for things like INDEX_NAME;
>> use static import instead.
>> - more efficiently compare special file names in update mode.
>> Update mode should be measurably faster.
>> - make CRC32OutputStream a nested class.
>> refactor crc32.reset and updating entry into CRC32OutputStream.
>> - Fix apparently benign bug updating n in CRC32OutputStream.write(byte,
>> int, int)
>> Evaluation: Yep.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the core-libs-dev