4206909 - adding Z_SYNC_FLUSH support to deflaters

Martin Buchholz martinrb at google.com
Thu Sep 3 23:06:38 UTC 2009

Here are review comments on your webrev


 308      * Returns actual number of bytes of compressed data.
 308      * Returns actual number of bytes of compressed data written
to the output buffer.


{@linke needsInput() needsInput}
{@link #needsInput()}


accumualte => accumulate

(yes, I know this is zlib's typo)


achieve the maximize => achieve the best


comparessed => compressed


 358      * so far (In particular the{@link #needInput needInput}
returns {code@ true}

add missing space
code@ => @code
needInput => needsInput

 178     public int available() throws IOException {
 179         ensureOpen();
 180         if (reachEOF) {
 181             return 0;
 182         } else {
 183             if (inf.needsInput())
 184                 return in.available();

Even if you could deal with the compatibility problems of applications
relying on the 1/0 existing specified behavior, this code
seems wrong because an inflater might possibly shrink the input.
Maybe you can use something like deflateBounds?
  8         if ("-client".equals(args[0]))

Confusing, because of hotspot flag with same name.
Are you trying to find a launcher bug?
How about "client" instead of "-client"?

Better yet, implement Flush as a single java program.


More information about the core-libs-dev mailing list