Code review request for 7002594 "Math.max and Math.min should use floatToRawIntBits() to check for -0.0"
joe.darcy at oracle.com
Wed Dec 1 14:33:49 PST 2010
Rémi Forax wrote:
> On 12/01/2010 06:24 PM, Joe Darcy wrote:
>> Please review my simple fix for
>> 7002594 "Math.max and Math.min should use floatToRawIntBits() to
>> check for -0.0"
>> Besides addressing the reported issues with max/min, I also review
>> the other uses of those methods in java.lang.* and added a comment or
>> two. While looking over sun/misc/FpUtils.java, I took the
>> opportunity to update the javadoc style.
> Looks fine.
> I just wonder why twoToTheDoubleScaleUp and twoToTheDoubleScaleDown in
> aren't real constants (static final).
Just an oversight; they are logically constants -- the next time I edit
this class, I'll fix that.
More information about the core-libs-dev