Review request for 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE
Mandy.Chung at Sun.COM
Tue Feb 9 05:36:12 UTC 2010
Daniel D. Daugherty wrote:
> Mandy Chung wrote:
>> Can you review the fix for:
>> 6924497: HotSpotDiagnosticsMXBean.getDiagnosticOptions throws NPE
>> Webrev at:
> line 95 - I don't local var 'c' is needed here or on line 99.
It was used for verification. It's no longer needed and I'll update it.
> No comments.
Thanks for the review.
> I'll be on the look out for the VM fix also.
>> The VM fix for 6898160 updates the jmm_GetVMGlobals function to
>> filter out unsupported type and the returning array may contain null
>> elements. The sun.management.Flag class needs to check for null
>> elements and handle unsupported types gracefully.
More information about the core-libs-dev