TEST_BUG: Tests in java/util/zip/ZipFile leave file open
xueming.shen at oracle.com
Thu Jun 17 12:15:06 PDT 2010
Thanks for the review.
InfoZip fails gracefully (increase the "failed" number) when test fails,
and if there is an unexpected
IO failure/exception the test fails anyway. So I did not add the
try/finally/close pattern. But, it
does not hurt to do that, so I added suggested anyway.
Same thing goes to the zos, the only bad thing could happen is the
unexpected IO failure/exception,
in which the test case fails anyway with an exception. Yes, I updated
the webrev to use the suggested
Copyright date has been updated accordingly as well.
Alan Bateman wrote:
> Xueming Shen wrote:
>> These tests leave either ZipFile or io stream open after testing,
>> fail in samevm mode, so are not in
>> ProblemList.txt now. With the change they now all pass.
> Good to see more tests coming off the "problem list".
> In test/java/util/zip/Info.java would it be nicer to put a try/finally
> around the usage of the ZipInputStream so that it closes even when the
> test fails. Same thing in test/java/util/zip/Comment.java. In
> ManyEntries.java it would also be nice to put a try/finally about the
> usage of zos.
> I notice you've changed the copyright date in 3 of the tests. I think
> the deal is that we are supposed convert it to a range and keep the
> original year (look at other files for examples). I think Kelly
> mentioned he's going to cook up a script that will occasionally fix up
> the second year, and save us needing to touch it.
More information about the core-libs-dev