Sponsor for 6666666: A better implementation of Character.isSupplementaryCodePoint

Martin Buchholz martinrb at google.com
Wed Mar 24 19:34:13 UTC 2010

On Wed, Mar 24, 2010 at 10:20, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
> Am 23.03.2010 23:59, schrieb Martin Buchholz:

> I too would like to see 8 spaces indentation on line breaks like:
>    if (aaaaaaaaaaaaaaa > bbbbbbbbbbbbb &&
>            ccccccccccccccc > ddddddddddddddddd)
>        doSomething();

This appears to be a new style (perhaps coming from the java IDEs?)
but it would be too pervasive a change for the JDK sources.

> + opening braces at line end instead beginning a new line

Perhaps too difficult/controversial?

> + blank line between package ... and import ...

This could be done, and automated.

> + no blank line between javadoc and class/method declaration


> + 2 spaces after period

I agree with this style, but there is not enough consensus.

> + proper indentation in @param @return @throws blocks

Perhaps too difficult to automate?

> + not too much use of braces e.g. for 1-line blocks (one can see more code
> lines on same screen space)

I agree with this personally, but there is violent disagreement
in the java programmer community.  E.g. google's style guide
requires braces everywhere.

> +
>     * @see    #forDigit(int, int)
>     * @see    Integer#toString(int, int)
> instead:
>     * @see     java.lang.Character#forDigit(int, int)
>     * @see     java.lang.Integer#toString(int, int)

I did a global s/java\.lang\.// in Character.java.

> +
>         * range: U+DC00 through U+DFFF
> instead
>         * range: 0xDC00 through 0xDFFF

I disagree.  The U+ notation should be reserved for
Unicode characters (code points) and not UTF-16
code units (which surrogates are).

> +
>    {@link #isLowSurrogate(char)}
>    {@link Character.UnicodeBlock}
> instead
>    {@linkplain #isLowSurrogate(char) isLowSurrogate}
> <code>{@link Character.UnicodeBlock UnicodeBlock}</code>

I've removed the <code> above.


More information about the core-libs-dev mailing list