Unicode script support in Regex and Character class
xueming.shen at oracle.com
Tue May 11 16:41:13 UTC 2010
Ulf Zibis wrote:
> SOME of my comments below ARE ment for
> I marked the others. ;-)
>>> - use Arrays.binarySearch() in Character.UnicodeBlock.of().
This one can be discussed in a separate thread, I would prefer to stay
with the script support in this review.
>>> - save UnicodeBlocks, BlockStarts and scriptStarts in a file instead
>>> statically in classfile.
>>> -- e.g. init of scriptStarts is a big waste of byte code (7/11 bytes
>>> per short/integer entry).
There are always different approaches, whatever approach you take , it
always has pros cons.
Lazy initialization, especially with data extracted to external
resource, is not always the best choice.
I truely believe it is not worth doing lazy initialization with external
data storage in this case (with
a total of 2k size difference).
More information about the core-libs-dev