Please review java.util.jar.pack.* exceptions
Alan.Bateman at oracle.com
Thu Nov 4 10:53:03 UTC 2010
Kumar Srinivasan wrote:
> Thanks for all the reviews and suggestions!
> the new version is at:
> In this revision:
> 1. the input parameter is renamed to "in",
> btw. we call out throwing of NPEs at the package level documentation
> I copied the same verbiage to the interfaces sections as well.
> 2. moved the exception check into scanJar, per Alan's suggestion
> where it is
> isolated to catch IllegalStateException and wraps it up into an IOE.
This looks much better. It may be slightly better to limit the handling
of the IllegalStateException to just the call to the JarFile's entries
method but I can't see anything else that might throw it so what you
have is fine with me.
On the test, I notice you compile with -XDignore.symbol.file but I don't
think that is needed. Also, it might be better to eliminate the
reference to a JCK test.
More information about the core-libs-dev