hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates
Alan.Bateman at oracle.com
Thu Nov 11 01:59:48 PST 2010
Lance Andersen - Oracle wrote:
> Hi Remi (and team),
> I made changes to SyncFactory and one other class for a similar error.
> Also cleaned up a couple of other minor issues in these classes.
> The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/
> Thank you for catching the error.
I've looked through the updated webrev, and I don't see anything
obviously wrong. I assume getJdbcRowSetResourceBundle could be a little
bit more efficient so that it only has to read jpResBundle twice rather
than 3 times during initialization but it's probably not an issue. You
know this already, but some of this code could do with more clean-up.
The formatting and code style is a bit inconsistent in places and of
course there are several unused static fields that someone else
mentioned. Doing this with a different CR make sense to me.
More information about the core-libs-dev