hg: jdk7/tl/jdk: 6843995: RowSet 1.1 updates

Lance Andersen - Oracle Lance.Andersen at oracle.com
Thu Nov 11 11:15:52 UTC 2010

Thank you Alan.

Yes I am planning on doing additional clean up across the code utilizing a separate CR.

On Nov 11, 2010, at 4:59 AM, Alan Bateman wrote:

> Lance Andersen - Oracle wrote:
>> Hi Remi (and team),
>> I made changes to SyncFactory and one other class for a similar error.  Also cleaned up a couple of other minor issues in these classes.
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/6982530/ <http://cr.openjdk.java.net/%7Elancea/6982530/>
>> Thank you for catching the error.
>> Regards
>> Lance
> I've looked through the updated webrev, and I don't see anything obviously wrong. I assume getJdbcRowSetResourceBundle could be a little bit more efficient so that it only has to read jpResBundle twice rather than 3 times during initialization but it's probably not an issue. You know this already, but some of this code could do with more clean-up. The formatting and code style is a bit inconsistent in places and of course there are several unused static fields that someone else mentioned. Doing this with a different CR make sense to me.
> -Alan.

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com

	Oracle is committed to developing practices and products that help protect the environment

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20101111/fd4e7ba3/attachment.html>

More information about the core-libs-dev mailing list