Please review java.util.jar.pack.* cleanup/refactoring/generificaiton
kumar.x.srinivasan at oracle.COM
Thu Nov 11 19:38:15 UTC 2010
> So some of these changes are using the new jdk7 language features?
> (diamond operator)
> Is this a first, or is this happening already? Just curious.
decided to use it, put NB on autopilot. :-)
> 460 return (layout == null ? "" == null :
> I'd use return "".equals(layout);
Will fix it.
> I wasn't able to look at much more, I'll try to later... Just thought
> I'd pass on what I saw.
> On Nov 11, 2010, at 9:29 AM, Kumar Srinivasan wrote:
>> Appreciate a review of the pack200 cleanup work, in the following areas:
>> 1. General generification of Collections.
>> 2. fixed worthy findbugs items.
>> 3. fixed worthy Netbeans nags.
>> 4. Elimination of array/generics combination.
>> The webrev is here:
More information about the core-libs-dev