Please review java.util.jar.pack.* cleanup/refactoring/generificaiton

Rémi Forax forax at
Thu Nov 11 20:04:46 UTC 2010

Le 11/11/2010 20:34, Kelly O'Hair a écrit :
> So some of these changes are using the new jdk7 language features? 
> (diamond operator)
> Is this a first, or is this happening already? Just curious.

It's not the first time. I have seen it time to time.
Mark (Reinhold) was the first to push a patch using the diamond operator 
in jigsaw tree.

>  460             return (layout == null ? "" == null : 
> layout.equals(""));
>    I'd use       return "".equals(layout);
> I wasn't able to look at much more, I'll try to later...  Just thought 
> I'd pass on what I saw.
> -kto


More information about the core-libs-dev mailing list