6989471: compiler warnings building java/zip native code
kelly.ohair at oracle.com
Thu Nov 18 22:28:31 UTC 2010
Looks good to me. Thanks for doing this.
On Nov 18, 2010, at 2:03 PM, Xueming Shen wrote:
> Alan, Kelly,
> Would you please help review the patch that tries to address those
> compiler warning
> in zip area?
> I added some comments to document the fact that ZIP_Read/FindEntry/
> InflateFully can't
> deal with > 2**32 byte (the only user of these native method is the
> vm, I don't think they
> are trying to de-compress a > 4G entry in one invocation any time
> soon). We might find
> interesting to support > 2**32 entry for those methods, but
> obviously it is not the purpose
> of this bug.
> Same for the "dstLen" of the compress/uncompress methods, the
> original zlib interface
> has the limitation of 2**32. I only tried to remove the warning in
> this patch.
> I'm not dealing with the POSIX strdup warning.
> It appears Kumar has already address the warning in zcrc32.c.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the core-libs-dev