Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.
Alan.Bateman at oracle.com
Tue Aug 16 04:35:26 PDT 2011
Sebastian Sickelmann wrote:
> some time ago, i wrote with Joe and David about advancing some
> exception-types to the 4 standard ctors.
> The first Exception i have looked at was InternalError and now(after
> some struggeling with gnumake and hg) my patches for reviewing are ready.
> I uploaded them at 
> I split the changes into 3 parts.
> 1. Added 2 ctors to InternalError and VirtualMachineError****
> 2. Use the two ctors of InternalError**** (based on )
> 3. Chain Rootcause into InternalError** (based also on )
> I think part 1 and 2 are uncritical. Part 3 is more critical because
> it changes behavior (exception-chaining). But i don't think that part
> 3 is unimportable, because in case of an InternalError (use should not
> be able to recover) there shouldn't be a problem with a little longer
> Is there someone who what to sponsor this or parts of it?
I don't have cycles but I can generate a webrev (essentially browsable
diffs) for you that would make this easy to review. Do you mind
re-basing your patches so that they can be applied to jdk8/tl/jdk? I
think Sasha got in before you and has already changesd several places to
use multi-catch that are in your patches too.
More information about the core-libs-dev