Request for review: Rework cause-chaining in Exceptions was:JDK 8 code review request for 6380161 (reflect) Exception from newInstance() not chained to cause.
sebastian.sickelmann at gmx.de
Wed Aug 17 14:31:58 PDT 2011
Am 17.08.2011 16:43, schrieb Sebastian Sickelmann:
> Am 17.08.2011 13:45, schrieb Alan Bateman:
>> joe.darcy at oracle.com wrote:
>>> I am willing to sponsor this work and I've filed bug 7080020 "Add
>>> conventional constructors to InternalError" for it.
>> Thanks Joe, and to help this along here's the webrev with Sebastian's
>> I haven't really looked but one thing I did notice is that the
>> multi-catch usages need to be checked as Sasha cleaned up a few of
>> these recently.
> Thanks for the webrev.
> I think it is very hard to start with the complete patch. Or is it
> better to review it all at once?
> I have created a webrev for my patches 0 and 1 and uploaded it here:
> After i have pulled from tl/jdk i got problems with building.
> I got warnings so that i must build with JAVAC_WARNINGS_FATAL=false,
> is this ok for tl-repo?
> -- Sebastian
Ok. Rebased again.
Now the webrevs are:
Unfortunatly after i have uploaded the webrev(takes some time because
128kbit/sek up is not the fastest)
there was a change that i not rebased on.
6237353: Remove sun.io package from j2se binary
rebasing on this removes some files in sun.io package these files should
be ignored while reviewing my webrevs.
If someone needs the rebased webrevs, let me know.
More information about the core-libs-dev