Request for Review: Chain more Exceptions (RuntimeException)
Alan.Bateman at oracle.com
Thu Aug 18 13:14:12 PDT 2011
Sebastian Sickelmann wrote:
> i have created a fix for fixing Exception-Chains in case of an
> rethrown RuntimeException.
> I am not quite sure if this is inside the scope of what i
> discussed with Joe. But it is
> fixed in the same manner as the patches there.
> Someone who wants to review / sponsor this?
I agree with Andrew that this is good clean-up.
I think the changes to
closer examination. Removing the 3 methods that it overloads should be
okay. Adding @since 1.8 to the existing constructor is not okay Removing
the cause field given that it's serializable, I need to remind myself
how this works.
A minor nit but I notice in many places where you've introduced
multicatch that you put the vertical bar at the beginning of the next
line whereas I think we've mostly been putting it on the right. In
src/share/classes/javax/management/relation/RelationService.java I see
you've got both. I don't know if coding conventions have been
established on this.
More information about the core-libs-dev