Reviewer needed - fix for regression test LastErrorString
Dr Andrew John Hughes
gnu_andrew at member.fsf.org
Fri May 6 11:46:09 UTC 2011
On 5 May 2011 20:45, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> Pavel Tisnovsky wrote:
>> Hi all,
>> I'd like to push fix for regression test
>> java/io/IOException/LastErrorString.java to OpenJDK7 and OpenJDK6. This
>> fix ensures that no system-important files can be erased and/or
>> rewritten by this test even if root started JTreg. Fixed test also tries
>> all various combinations of file attributes.
>> Webrev is available at:
>> Can anybody please review it?
>> Thank you in advance,
>> Pavel Tisnovsky
> I agree that this test should be fixed but I don't know about jdk7 as it's
> being stabilized now and only critical changes are allowed.
Pavel submitted the patch for OpenJDK7, not jdk7.
> From a quick glance it looks like you've added the @test tag to both files
> so I assume jtreg will want to run it twice. Have you tried the test on
> Windows? I assume it will at least fail with "Unrecognized system" if run
> with Cygwin. In general it's best to avoid scripts if you can - in this case
> have you considered created an unreadable and unwriteable file in java
We don't build on Windows.
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the core-libs-dev