Garbage collection race condition before final checks
gary.adams at oracle.com
Tue Nov 15 10:20:09 PST 2011
Updated the webrev
- renamed variable to "test"
- removed reset to null
- removed extra parens in exception message
- updated @bug tag
I have never seen the failure with PlatformLoggingMXBeanTest,
and I had previously done a gc right after the Logger assignment.
Seems to be a reasonable update to use the instance variables
in case the previous failures were caused by the logger being gc'ed.
On 11/15/11 12:57 PM, Mandy Chung wrote:
> On 11/15/11 04:26, Gary Adams wrote:
>> Added PlatformLoggingMXBeanTest to the 7067691 bug fix,
>> e.g. instance variables for Logger variables to prevent premature
>> weak reference collection.
> LoggingMXBeanTest.java: As Alan suggests, it'd be better to rename
> "lmxbeantest". I think simply "test" would do it.
> L70: resetting null is not needed.
> L232, 234: "(" and ")" brackets don't seem to be needed
> Similar comments as I gave to LoggingMXBeanTest.java: need to add the CR #
> to @bug. L48-49: a comment will prevent someone to back out this change to
> keep a strong reference in the future.
> Are you able to reproduce the test failure without moving L140-141?
More information about the core-libs-dev