Code Review Request: 7157893: Warnings Cleanup in java.util.*
forax at univ-mlv.fr
Mon Apr 16 15:48:09 PDT 2012
On 04/17/2012 12:26 AM, Stuart Marks wrote:
> On 4/16/12 1:18 PM, Kurchi Hazra wrote:
>> Sorry, I forgot to insert a link to the webrev :
>> On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
>>> On 4/13/2012 8:26 PM, Mike Duigou wrote:
>>>> Looks good for commit. Just a few notes
>>>> maskNull seemed to have the unchecked cast well bottlenecked. Why
>>>> move the
>>>> cast outside of unmaskNull() and thus require
>>>> in many other places.
>>> I agree with this one. I have updated EnumMap.java to remove cast in
>>> unmaskNull() and then remove the unrequired casts. (and some changes
>>> in 724,
>>> 740 and 789 while I was there)
> I should point out that I had previously mentioned the casting in
> unmaskNull but that Remi had disagreed . I was content to let
> Remi's recommendation stand but since Mike raised it again, and Kurchi
> agreed, I guess that Remi has been outvoted while I distracted him by
> discussing generic reification. :-)
> Anyway I think this latest webrev is fine.
I'm too busy to prepare my talk to devoxx france,
so you can push any patch you want.
Or more seriously, I will not be the man known to have written
a long mail to explain why a cast should be in the callers and not in
so thumb up, for me.
More information about the core-libs-dev