Review for 7157656 (zipfs) SeekableByteChannel to entry in zip file...
Alan.Bateman at oracle.com
Tue Apr 17 02:50:10 PDT 2012
On 16/04/2012 17:55, Paul Sandoz wrote:
> I ain't got permission to publish webrevs yet. So attached is a patch produced by hg export on the jdk tree for:
> 7157656 (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0
Sherman wrote this zip provider and I assume will want to review this so
I'll leave it to him.
One thing I notice, and nothing to do with your patch, is that the
position(long) method is missing an implementation, it shouldn't throw
UOE. Also for the append case it looks like read throws UOE whereas it
should throw NonReadableChannelException.
More information about the core-libs-dev