RFR: 8003596 CheckLockLocationTest-Windows-fix

Jim Gish jim.gish at oracle.com
Mon Dec 3 15:01:43 UTC 2012

Thanks.  Could you please push the change.


On 12/01/2012 10:44 AM, Alan Bateman wrote:
> On 30/11/2012 23:19, Jim Gish wrote:
>> Please review 
>> http://cr.openjdk.java.net/~jgish/Bug8003596-CheckLockLocationTest-Windows-fix/ 
>> <http://cr.openjdk.java.net/%7Ejgish/Bug8003596-CheckLockLocationTest-Windows-fix/> 
>> Summary: fixes test when running on Windows so that test that 
>> requires setWritable is not run, because Windows does not support 
>> setWritable.
>> Thanks,
>>    Jim
> Looks okay to me although "if (!isWindows())" to "if (!ON_WINDOWS)" 
> might be neater. An alternative way to do this would be just to handle 
> check the return from setWritable rather than failing. It is possible 
> to change the deny adding entries to directories with the new file 
> system API but it's probably not worth using it here.
> -Alan.

Jim Gish | Consulting Member of Technical Staff | +1.781.442.0304
Oracle Java Platform Group | Core Libraries Team
35 Network Drive
Burlington, MA 01803
jim.gish at oracle.com

More information about the core-libs-dev mailing list