Review request: JDK-8004928 TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem.
Alan.Bateman at oracle.com
Wed Dec 12 18:40:57 UTC 2012
On 12/12/2012 15:41, Alexey Utkin wrote:
> Bug description:
> Here is the suggested fix:
This mostly looks good to me, just a few comments:
For java/io/Serializable/resolveProxyClass/NonPublicInterface.java and
java/lang/reflect/Proxy/ClassRestrictions.java then it would be nice if
the types used were in compact1 , that would avoid needing to exclude
those tests. I also see the test uses sun.tools.agent.StepConstants
which I don't think exists but perhaps that is intentional.
test/java/util/Collections/EmptyIterator.java, minor nit but I think we
prefer "public static" over "static public". It doesn't of course need
to be public anyway.
You probably saw Dan's comment about changing
test/java/util/logging/LoggingDeadlock4.java, I trust you'll double
check this test with an older version of the JDK that doesn't have the
fix. My only comment is that line 46 is too wide.
More information about the core-libs-dev