Review request: JDK-8004928 TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem.
mandy.chung at oracle.com
Wed Dec 12 18:59:37 UTC 2012
On 12/12/12 7:41 AM, Alexey Utkin wrote:
> Bug description:
> Here is the suggested fix:
Looks good in general with some minor comments below.
> The set of non-public interfaces was changed to avoid AWT
These 2 tests look for the first non-public system interface. Instead
of keeping the nonPublicInterfaces list, it may be good to simplify this
to use "java.util.zip.ZipConstants" which seems to be a stable one that
will unlikely be removed. I would suggest to add a check that the class
is non-public (Modifier.isPublic) to catch any future change to this class.
> The ballast calls
> were removed from compiled Java code. Compilation time still
> The dependence from the internal class
> was excepted from code. It has very small impact to test
> Swing-stored constants were changed to locally-defined.
I believe your change captures what it's intended to test (typed
enumeration and rawtype enumeration). Minor comment - it might be
better to move the new static variables as local variable before calling
testEmptyEnumeration to be consistent with convention used in this
test. There is no need to keep them static anyway. I would also take
out the comment about the substitution since this test doesn't seem to
have any relationship with javax.swing.
> Test case was simplified to avoid AWT class loading. Negative
> test result was tested on early
> JDK7 build.
Looks good. Nit: L46 - good to break it into 2 lines. It's good that
you have verified with and without the fix.
> Useless mention of XToolkit was removed from the script.
More information about the core-libs-dev