Review request: JDK-8004928 TEST_BUG: Reduce dependence of CoreLib tests from the AWT subsystem.
Daniel D. Daugherty
daniel.daugherty at oracle.com
Thu Dec 13 14:58:04 UTC 2012
On 12/13/12 2:35 AM, Alexey Utkin wrote:
> On 12.12.2012 20:52, Daniel D. Daugherty wrote:
>> On 12/12/12 9:47 AM, Alan Bateman wrote:
>>> On 12/12/2012 16:36, Daniel D. Daugherty wrote:
>>>> For this item:
>>>> > test/java/util/logging/LoggingDeadlock4.java
>>>> > Test case was simplified to avoid AWT class loading.
>>>> Negative test
>>>> > result was tested on early JDK7 build.
>>>> if I remember correctly, the whole point of that test was to
>>>> check for a logging deadlock relative to AWT's usage of logging.
>>>> If you avoid loading AWT classes, doesn't that make the test
>>>> rather useless?
>>> private static final PlatformLogger log =
>>> private static final PlatformLogger eventLog =
>>> and the updated test is just using PlatformLogger directly,
>> I thought the deadlock had to do with locks grabbed on the way
>> to getting into the underlying PlatformLogger, but my memory is
>> hazy and I don't have the cycles to research this.
>>> I hope it demonstrates the same issue with a JDK that doesn't have
>>> the fix.
>> That would be the right way to see if the test still "works".
> Yes, it works!*
> test result: Error. Program `C:\Program Files\Java\jdk1.7.0\bin\java'
> interrupted! (timed out?)*
Thanks for letting me know.
More information about the core-libs-dev