RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)
daniel.fuchs at oracle.com
Tue Dec 18 22:04:56 UTC 2012
On 12/18/12 7:38 PM, Joe Wang wrote:
> Hi Daniel,
> Looks great! I see you've added many verifications.
> One minor note, creationMethod is used in place of the object
> instance for the creationMethod.invoke call, although it's ignored for
> a static method anyways. Is there a reason for doing that?
Yes sorry about that - it's my mistake. I had wrapped that call in a
previous version then decided to revert
to the original code but I obviously did it too fast!
Thanks for catching it - the tests didn't!
> On 12/18/2012 8:42 AM, Daniel Fuchs wrote:
>> Here is a new webrev in the series that addresses using ServiceLoader in
>> JAXP for JDK 8.
>> 7169894: JAXP Plugability Layer: using service loader
>> This changeset addresses modification in the javax.xml.transform
>> It is similar to changes proposed for the javax.xml.parsers
>> package , with only a few differences due to the specificity of
>> best regards,
>> -- daniel
>> previous webrevs in the series:
>>  javax.xml.parsers:
>>  javax.xml.datatype:
>>  javax.xml.stream
More information about the core-libs-dev