JDK 8 code review request for 8005042 Add Method.isDefault to core reflection
joe.darcy at oracle.com
Tue Dec 18 22:32:58 UTC 2012
Mandy and Jim,
I'll correct the typos before I push.
Thanks for the careful review,
On 12/18/2012 01:21 PM, Mandy Chung wrote:
> On 12/18/12 12:43 PM, Joe Darcy wrote:
>> Please review these changes to add core reflection support to
>> recognize default methods:
>> 8005042 Add Method.isDefault to core reflection
> Looks good to me.
> For the test:
> 56 System.err.printf("ERROR: On %s expected isDefualt of ''%s''; got ''%s''.\n",
> 57 method.toString(), expected, actual);
> A typo 'isDefualt' -> 'isDefault'. This uses two single-quote
> characters to wrap the expected and actual value - is it intentional?
> I was wondering that you meant to use one singe-quote character.
More information about the core-libs-dev