RFR 8004547: Extend JavaFX launcher support...

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Dec 21 16:42:28 UTC 2012


It looks great here are few items I noticed:
1. The error defined by:

+    Error: The JavaFX runtime is incompatible with the Java launcher

  is used for a signature mismatch, I suggest changing the
  message to reflect the real reason.

2. Nit:  extraneous new lines, maybe ?

3. typo:

525     // Check the existance and signature of main and abort if it's incorrect
525     // Check the existence and signature of main and abort if incorrect



-System.out.println("Main-Class: "+mainClassEntry);
+System.out.println("Main-Class: " + mainClassEntry);


> Request for review for extending the launcher support to allow the JavaFX runtime to fully support all of it's launch features, including preloaders, classpath, etc..
> Webrev:
> http://cr.openjdk.java.net/~ddehaven/8004547/webrev.1/
> Corresponding JavaFX JIRA issue that these changes depend on:
> http://javafx-jira.kenai.com/browse/RT-26751
> This should be the final step in adding launcher support for JavaFX applications. These changes should allow any future changes to be done entirely in the JavaFX runtime. The changes for RT-26751 are in this weeks promotion of JavaFX, so should be available in next weeks JRE build (I think.. I'm never sure about promotion timing..).
> -DrD-

More information about the core-libs-dev mailing list