RFR 8005280: (props) Improve test coverage for small XML parser

Alan Bateman Alan.Bateman at oracle.com
Fri Dec 21 20:35:16 UTC 2012

On 21/12/2012 19:56, Joe Wang wrote:
> :
> I searched by properties.dtd and found the CDATA usage. So I went 
> ahead experimenting what would not be  rejected by the regular 
> provider and tested against the small parser.  I agree the cases other 
> than CDATA are rare.

>> In CompatibilityTest.loadPropertyFile then it looks like the file is 
>> not closed.
> Properties' loadFromXML stated that it will close the stream after 
> loading. But it doesn't hurt to double-check.
> New webrev:
> http://cr.openjdk.java.net/~joehw/jdk8/8005280/webrev/
What you have now is okay but I think it would be nicer if it were 
changed to use try-with-resources (no need to generate a new webrev for 


More information about the core-libs-dev mailing list