RFR 8005280: (props) Improve test coverage for small XML parser

Joe Wang huizhe.wang at oracle.com
Fri Dec 21 21:18:15 UTC 2012

On 12/21/2012 12:35 PM, Alan Bateman wrote:
> On 21/12/2012 19:56, Joe Wang wrote:
>> :
>> I searched by properties.dtd and found the CDATA usage. So I went 
>> ahead experimenting what would not be  rejected by the regular 
>> provider and tested against the small parser.  I agree the cases 
>> other than CDATA are rare.
> Okay.
>>> In CompatibilityTest.loadPropertyFile then it looks like the file is 
>>> not closed.
>> Properties' loadFromXML stated that it will close the stream after 
>> loading. But it doesn't hurt to double-check.
>> New webrev:
>> http://cr.openjdk.java.net/~joehw/jdk8/8005280/webrev/
> What you have now is okay but I think it would be nicer if it were 
> changed to use try-with-resources (no need to generate a new webrev 
> for that).

I still have the source=1.5 mentality :)  In 2009, we dropped JDK 1.4 
support for the jaxp standalone. I guess it's time to make a jump to 
source=1.7 now!

I re-generated the webrev just to keep the record.  I will push after a 
new jprt test.


> -Alan

More information about the core-libs-dev mailing list