Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node
Alan.Bateman at oracle.com
Wed Jul 11 12:45:01 UTC 2012
On 26/06/2012 22:57, Kurchi Hazra wrote:
> On Mac OS X, for Preferences, a new child added event was not being
> delivered to a NodeChangeListener since the existing code depended on the
> return value of addNode() in the native code, which returns true if a new
> node is added. However, since addNode() was being called erroneously
> a child node is already added to an existing node, addNode() would always
> return false, resulting in thw new node event never being delivered.
> This fix propagates the required information of whether a node is
> added from
> the method adding the child node itself. In addition, I cleaned up the
> constructors in MacOSXPreferences.java and added a test
> (AddNodeChangeListener.java) to cover this case.
> Finally, there were two prefs tests in ProblemList.txt which are now
> I have removed these from the ProblemList too.
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7160252
> Webrev: http://cr.openjdk.java.net/~khazra/7160252/webrev.00/
It doesn't look you got a reviewer for this one.
I looked at the changes and the fix seems okay to me. The only odd thing
is that now that you have the 5-arg constructor then it can initialize
all the fields allowing you to get rid of initFields and also setNew.
Also I assume it means you can close 7150557.
More information about the core-libs-dev