Suggestion about including pthread.h
Alan.Bateman at oracle.com
Thu Mar 8 11:25:37 UTC 2012
On 08/03/2012 08:09, Shi Jun Zhang wrote:
> There is still no reply from build infra project and even if it is in
> build infra, it will take a long time to merge back to trunk. But this
> including pthread problem really affects AIX platform. I'm thinking we
> can use #ifndef __solaris__ form because all other POSIX-conformant
> platforms (BSD, Mac, AIX, ...) except Solaris need to include pthread.h.
> Here is the webrev:
Kumar will likely have an opinion on java_md.c/ContinueInNewThread0.
Personally I would go for #ifdef __solaris ... #end ... #endif rather
than #ifndef __solaris__.
I don't think the changes to NativeThread.c are quite right because it
assumes that we need to signal threads on platforms other than Solaris
and it also assumes the signal is __SIGRTMAX - 2. I don't know what you
use in your AIX port but once the preemptive close issues are sorted out
on Mac then I assume it will be SIGIO. So for this one I would suggest
the ifdef in the init, current and signal methods be ifdef INTERRUPT_SIGNAL.
The change to socket_md.c looks okay to me but you will need to re-base
your patch due to the Mac port in jdk8/tl.
More information about the core-libs-dev