[PATCH FOR REVIEW] ResourceManager.getApplicationResources() does not close InputStreams
ahughes at redhat.com
Wed Nov 7 20:30:18 UTC 2012
IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
com.sun.naming.internal.ResourceManager.getApplicationResources() does not close the input streams it gets from helper.getResources() and helper.getJavaHomeLibStream(). This patch:
adds finally blocks to close these streams. As noted in the original bug report, this has been tested on a J2EE
server (JBoss) without issue.
I realise that there's a possibility that try-with-resources could be used here, but the patch as posted
is the one that was tested and I don't want to negate that testing by changing it.
Ok for tl? If so, can I have a bug ID for this?
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
More information about the core-libs-dev