code review request: Test case for JDK-7198904 TreeMap.clone issue
mike.duigou at oracle.com
Tue Nov 20 17:05:00 UTC 2012
Looks good. Thank you for making the change.
On Nov 20 2012, at 04:55 , David Buck wrote:
> > The one possible addition is to check that m1 hasn't been modified
> > after the mutation of m2.
> Sounds good. I have added the second test and retested against both OpenJDK and OracleJDK builds:
> [ Code Review for jdk ]
> Would someone please review this new version of the test case?
> On 11/16/12 11:45, Mike Duigou wrote:
>> Looks like a good test to me as well. The one possible addition is to check that m1 hasn't been modified after the mutation of m2.
>> On Nov 14 2012, at 05:38 , David Buck wrote:
>>> This is a review request to add only the test case for the following OracleJDK issue:
>>> [ 7198904 : (alt-rt) TreeMap.clone is broken ]
>>> The issue (root cause) is not in OpenJDK (i.e. the problem was OracleJDK specific), but the test case is valid for both so it should go into OpenJDK so we can prevent a similar issue from ever happening in both releases moving forward.
>>> [ Code Review for jdk ]
>>> The OracleJDK fix (closed source) is ready and has already passed code review. I intend to push both the OracleJDK fix and this test case into their respective repositories at the same time once this review is done.
More information about the core-libs-dev