Code Review Request: 7197662: (prefs) java/util/prefs/AddNodeChangeListener.java fails by timeout or by "couldn't get file lock"
chris.hegarty at oracle.com
Fri Sep 21 09:03:50 UTC 2012
On 21/09/12 01:12, Dan Xu wrote:
> Can you append bug number 7197662 to @bug field in each test so that it
> is easy to check its history?
Yes, this is always a good idea.
> For your changes, I wonder why you choose to run these tests in othervm
> mode. Thanks!
The tests need to run in othervm mode as they are now setting a system
property. We don't want this system property to inadvertently effect
other tests, if a batch are being run in samevm or agentvm.
Assuming that '.' means the scratch directory when jtreg is running,
then I'm fine with these changes.
> On Thu 20 Sep 2012 02:22:15 PM PDT, Kurchi Hazra wrote:
>> The tests in java/util/prefs creates new nodes under the user's home
>> This causes the tests to start out with pre-existing preferences and
>> leads to interference between the tests. This fix is to change the
>> property for each of these tests so these tests create nodes only
>> under the
>> current directory.
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7197662
>> Webrev: http://cr.openjdk.java.net/~khazra/7197662/webrev.00/
>> - Kurchi
More information about the core-libs-dev