Code review request for 6298888 (reflect) Add toGenericString to java.lang.Class and java.lang.reflect.Type

Alan Bateman Alan.Bateman at
Fri Apr 5 12:46:13 UTC 2013

On 03/04/2013 17:38, Joe Darcy wrote:
> Hi Peter,
> On 04/03/2013 01:26 AM, Peter Levart wrote:
>> Hi Joe,
>> Why not using StringBuilder instead of StringBuffer in 
>> Class.toGenericString ?
> No reason. Thanks for catching this; I'll use StringBuilder in the 
> final push.
Modifier.toString can probably be updated too.

I looked through the changes and they look okay to me. For the 
toGenericString javadoc then "formatted as a list" might be better than 
"formatted as list".


More information about the core-libs-dev mailing list